Rust improvements #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gasbytes
commented
Feb 6, 2025
gasbytes
commented
- Switch from Vec to fixed-size Box<[u8]> arrays in rustls-wolfcrypt-provider key exchange operations.
- Adds detailed error categories and unit tests for error handling.
gasbytes
force-pushed
the
rust-improvements
branch
from
1b6efc9 to
da9dff9
Compare
gasbytes
force-pushed
the
rust-improvements
branch
from
da9dff9 to
c385478
Compare
Contributor
|
@gasbytes please resolve merge conflict. |
- refactor(build.rs): unravel nested if/else in build.rs
Split build script into modular functions with proper error handling.
Add documentation and extract constants for better maintainability.
- refactor(lib): minimize unsafe blocks in RSA encryption test
…orized errors Add detailed error categories for wolfSSL error codes while maintaining the original API. Implement Display trait and add internal error checking mechanism. Keep no_std compatibility and add comprehensive tests.
Switch from Vec<u8> to Box<[u8]> and fixed-size arrays in key exchange implementations since crypto keys have known sizes. This reduces heap allocations and improves memory efficiency with no functional changes.
gasbytes
force-pushed
the
rust-improvements
branch
from
c385478 to
a213bb8
Compare
Improves safety by loggin cleanup failures instead of panicking during resource drops. This prevents crashed while preversing error information for debugging.
gasbytes
force-pushed
the
rust-improvements
branch
from
a213bb8 to
9cfb191
Compare
dgarske
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.